There are plenty of people who don’t receive US residency even after marrying US citizens, as they expected.
I know a Chilean woman who was living with her boyfriend in NY who and already became a citizen. They got married, but she still had to go back to Chile.
Right now, immigration laws are favorable (no ban on Chinese immigrants like before). But Trump’s domestic policy adviser, Stephen Miller, is a neo nazi who wants to end chain migration and birthright citizenship.