Is the production of porn legal in Taiwan for expats? Can you recommend a good lawyer?

Not really.

There are always niche opportunities, but if you want to do serious, profitable production, you need access to talent and a reasonably accommodative environment.

It sounds like the OP and his friend just want to live in Asia and Taiwan looked like it might pass the “is porn production legal?” filter. In reality, porn is produced everywhere. In countries where it’s of dubious legality or totally illegal, commercial production is almost always an underworld thing that you’re healthier avoiding. Even in places where it’s legal, there can be a lot of shadiness you’d want to avoid, especially if you’re a foreigner with no connections/protection.